This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(sg): add version=auto for sg release cut#62970
Merged
Merged
Conversation
BolajiOlajide
approved these changes
May 29, 2024
Contributor
There was a problem hiding this comment.
This looks good to me.
Thank you @Chickensoupwithrice .
However, it seems like we have this logic duplicated now. It might be helpful to have this in a function and call it in the "sg release cal" and "sg release create" command which accepts the "--version=auto" flag.
We don't have to do this now, I just thought to share here.
Contributor
|
Ignore me |
Contributor
Author
|
It seems like it might still be a good idea to have a function to parse version across all the different subcommands |
Contributor
Author
|
Testing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the version number had to be specified explicitly during the
sg release cutcommand. Now we can optionally pass--version=autoto query release-registry for the next version.We need this in both places, since on main cut releases, this is the first step that happens, but during patch releases, the first step is
sg release createwhich also has--version=auto.Test plan
Tested manually
Changelog
--version=autotosg release cut