This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Adding the User param to the site config so that it can be supported by Azure as an extra param#62950
Merged
Merged
Conversation
… by Azure as an extra param
b20650a to
c4da6ea
Compare
… by Azure as an extra param
… by Azure as an extra param
dominiccooney
approved these changes
May 28, 2024
dominiccooney
left a comment
There was a problem hiding this comment.
LGTM, I assume the ,omitempty is all we need to make this a no-op for models who do not use it and sites which do not specify it.
| "type": "string" | ||
| }, | ||
| "user": { | ||
| "description": "Its the user field for OpenAI config for both AzureOpenAI and OpenAI", |
There was a problem hiding this comment.
Just "The ...", we don't need "Its ..."
(Its is possessive anyway and definitely wrong.)
… by Azure as an extra param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See what the field Does
Test plan
Tested locally by setting up extra variable in siteadmin with azure config and it worked perfectly.