Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Rename smartContext to smartContextWindow#62948

Merged
abeatrix merged 2 commits into
mainfrom
bee/rename
May 28, 2024
Merged

Rename smartContext to smartContextWindow#62948
abeatrix merged 2 commits into
mainfrom
bee/rename

Conversation

@abeatrix

Copy link
Copy Markdown
Contributor

Requested by @aramaraju :

@kalan raised a good point that the smartContext may have some misleading connotations to it, especially with enhanced context likely going away and OpenCTX adding new sources.
My suggestion is that we smartContextLimits or smartContextWindow might convey the messaging stronger.
I'm hoping it's a small enough change for us, but I will let you chime in on that to see if this is something we should do before the release is cut

image

Rename the smartContext configuration option to smartContextWindow

Changelog

Test plan

Green CI. No feature changes. Just renaming an unreleased configuration option.

@cla-bot cla-bot Bot added the cla-signed label May 28, 2024

@kalanchan kalanchan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@kalanchan kalanchan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abeatrix missed one more

Comment thread CHANGELOG.md Outdated
Co-authored-by: Kalan <51868853+kalanchan@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants