This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(local): catch bazel-do issues before push#62943
Merged
jhchabran merged 1 commit intoMay 28, 2024
Merged
Conversation
burmudar
approved these changes
May 28, 2024
Contributor
|
@jhchabran one depguard failure but I've approved to not block |
0de195c to
67d1e68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, you could end up pushing a
bazel-doruntype build that is disallowed, which is not the nicest feedback loop as you'll only hear back about the problem once the CI picked it up.Now the command straight up tells you before anything else. I also added a basic How-to covering this and linked to it in the extended usage description.
Changelog
Test plan
CI + locally tested.