Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

SSC: Add "Welcome to Cody Pro" banner#62936

Merged
vdavid merged 6 commits into
mainfrom
dv/ssc-welcome-to-cody-pro-banner
May 28, 2024
Merged

SSC: Add "Welcome to Cody Pro" banner#62936
vdavid merged 6 commits into
mainfrom
dv/ssc-welcome-to-cody-pro-banner

Conversation

@vdavid

@vdavid vdavid commented May 27, 2024

Copy link
Copy Markdown
Contributor

Contributes to https://github.com/sourcegraph/self-serve-cody/issues/725

We currently don't welcome the user when they first arrive at the Cody Management page. This PR adds a notification.

The changes, each in their own commits:

  1. Add the notification to the /cody/manage page
  2. Trigger the notification after a user signs up using our new checkout page (the old one is hosted on the SSC site)
  3. Trigger the notification after a team invitee accepts the invitation

Unrelated change: fix a header style in the "Team invites" section

Note: for the pic, I used a 4x PNG. The graphic uses gradients that SVG doesn't seem to support (figma export messes up the pic).

Test plan

  • 2-min Loom where I demo that the notification gets triggered in both the "Checkout" and "Accept invite" flows.

The notification looks like:

CleanShot 2024-05-28 at 00 40 52@2x

and

CleanShot 2024-05-28 at 00 40 26@2x

and they are based on this figma:

CleanShot 2024-05-28 at 00 42 06@2x

@cla-bot cla-bot Bot added the cla-signed label May 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed like the bucket where we host stuff like these.
I couldn't use an SVG this time because the type of gradient used in the graphics is not supported by SVG. The PNG was too large for BASE64+embedding.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wires up the new notification to invite accept events.

Comment on lines 109 to 116

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the notification here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wires up the new notification to successful checkouts.

@vdavid vdavid marked this pull request as ready for review May 28, 2024 11:24
@vdavid vdavid requested a review from a team May 28, 2024 11:24

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning fix

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This restores the styling I removed in https://github.com/sourcegraph/sourcegraph/pull/62888/commits/65932b8d5a23be5b51f3064a69a1c84e8a712f92
@taras-yemets, that CSS was needed after all. 🤷‍♂️

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taras-yemets, I pressed the wrong shortcut and GitHub didn't submit this comment before. Just wanted to highlight that we both missed this. 🤦

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now I see you're trying to reduce the font weight on <h2>.

@vdavid vdavid force-pushed the dv/ssc-welcome-to-cody-pro-banner branch from 9bbf227 to 3ee4647 Compare May 28, 2024 11:44
@vdavid vdavid enabled auto-merge (squash) May 28, 2024 11:45
@vdavid vdavid merged commit 7375a27 into main May 28, 2024
@vdavid vdavid deleted the dv/ssc-welcome-to-cody-pro-banner branch May 28, 2024 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants