Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix(local): panic in sg ci preview#62928

Merged
jhchabran merged 1 commit into
mainfrom
jh/fix-sg-ci-preview
May 27, 2024
Merged

fix(local): panic in sg ci preview#62928
jhchabran merged 1 commit into
mainfrom
jh/fix-sg-ci-preview

Conversation

@jhchabran

@jhchabran jhchabran commented May 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Noticed a panic when running sg ci preview, which was has been introduced when we refactored some funcs in the gitops package.

Test plan

Before: panic
After:

~/work/other U jh/fix-sg-ci-preview $ sg bazel run //dev/sg -- ci preview
INFO: Invocation ID: c9bd6cea-8847-4e1b-aebf-d3a963a22e0c
INFO: Analyzed target //dev/sg:sg (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //dev/sg:sg up-to-date:
  bazel-bin/dev/sg/sg_/sg
Aspect @@rules_rust//rust/private:rustfmt.bzl%rustfmt_aspect of //dev/sg:sg up-to-date (nothing to build)
Aspect @@rules_rust//rust/private:clippy.bzl%rust_clippy_aspect of //dev/sg:sg up-to-date (nothing to build)
INFO: Elapsed time: 0.311s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: bazel-bin/dev/sg/sg_/sg ci preview
If the current branch were to be pushed, the following pipeline would be run:

  Parsed diff:                                                                                                                                                                                            
  changed files: [dev/ci/internal/ci/config.go]                                                                                                                                                           
  diff changes: "Go"                                                                                                                                                                                      
  The generated build pipeline will now follow, see you next time!                                                                                                                                        
                                                                                                                                                                                                          
  • Detected run type: Pull request                                                                                                                                                                       
  • Detected diffs: Go                                                                                                                                                                                    
  • Computed variables:                                                                                                                                                                                   
    • VERSION=jh-fix-sg-ci-preview_00000_2024-05-27_5.4-c63ad06c59cc                                                                                                                                      
  • Computed build steps:                                                                                                                                                                                 
    • Aspect Workflow specific steps                                                                                                                                                                      
      • 🤖 Generated steps that include Buildifier, Gazelle, Test and Integration/E2E tests                                                                                                               
    • :bazel: Bazel prechecks & build  sg                                                                                                                                                                 
    • :bazel:⏳ BackCompat Tests                                                                                                                                                                          
    • :bazel:🧹 Go mod tidy                                                                                                                                                                               
    • Linters and static analysis                                                                                                                                                                         
      • 🍍:lint-roller: Run sg lint → depends on bazel-prechecks                                                                                                                                          
    • Security Scanning                                                                                                                                                                                   
      • Semgrep SAST Scan

@cla-bot cla-bot Bot added the cla-signed label May 27, 2024
@jhchabran jhchabran requested a review from a team May 27, 2024 12:44
@jhchabran jhchabran force-pushed the jh/fix-sg-ci-preview branch from c63ad06 to 8484fd9 Compare May 27, 2024 12:44
burmudar
burmudar approved these changes May 27, 2024
View reviewed changes

@burmudar burmudar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏼

@jhchabran jhchabran force-pushed the jh/fix-sg-ci-preview branch from d9af651 to 4e74d8d Compare May 27, 2024 12:52
@jhchabran jhchabran merged commit 75bd631 into main May 27, 2024
@jhchabran jhchabran deleted the jh/fix-sg-ci-preview branch May 27, 2024 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@burmudar burmudar burmudar approved these changes

@Strum355 Strum355 Strum355 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhchabran @burmudar @Strum355