This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
janhartman
approved these changes
May 27, 2024
vdavid
reviewed
May 27, 2024
| type upstreamHandlerMethods[ReqT UpstreamRequest] interface { | ||
| // getAPIURLByFeature returns the upstream API endpoint to call for the given feature. | ||
| getAPIURLByFeature(codygateway.Feature) string | ||
| getAPIURL(codygateway.Feature, ReqT) string |
Contributor
There was a problem hiding this comment.
I see that the implementations of this method always ignore the second parameter, except the new GoogleHandler, but that only uses req.ShouldStream() (a bool) and req.Model (a string).
It feels meh. But the best alternative I could come up with it to use the feature argument and concat the two values as a string with some separator, but that's even uglier. So 👍 , just wanted to note that I thought about it and ack that this is the best solution we found without major changes.
Contributor
Author
There was a problem hiding this comment.
UpstreamRequest only has 3 properties (GetModel() ShouldStream() and BuildPrompt(), so I decided that Google using 2/3 is close enough to pass the whole request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Google Gemini models as exposed by AI Studio API.
Slack context.
Closes AI-50.
Test plan