Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(sg): cloud ephemeral - account for conclusion field#62925

Merged
burmudar merged 1 commit into
mainfrom
wb/sg/update-cloud-status-format
May 27, 2024
Merged

chore(sg): cloud ephemeral - account for conclusion field#62925
burmudar merged 1 commit into
mainfrom
wb/sg/update-cloud-status-format

Conversation

@burmudar

Copy link
Copy Markdown
Contributor

The reason field my contain , conclusion and sometimes it might not. This accounts for this case and gracefully handles it it is missing

Test plan

Tested locally
Failure

go run ./dev/sg cloud eph status --name wb-feature-x --raw
❌ getting status of "wb-feature-x" failed
❌ failed to parse status reason: "step 1/3:creating instance, job-url:https://github.com/sourcegraph/cloud/actions/runs/9251869285, state:completed, conclusion:failure" 7
exit status 1

Fixed

go run ./dev/sg cloud eph status --name wb-feature-x --raw
✅ Ephemeral instance "wb-feature-x" status retrieved
Ephemeral instance details:
ID           : src-1eadb696458496ba7407
Name         : wb-feature-x
InstanceType : internal
Environment  : dev
Version      : wb-feature-x_275730_2024-05-27_5.4-d23e2bfd524d
URL          : https://wb-feature-x.sgdev.dev
AdminEmail   :
CreatedAt    : n/a
DeletetAt    : n/a
ExpiresAt    : n/a
Project      : src-94593c750106b959d519
Region       : us-central1
Status       : in-progress
Step         : 1/3
Phase        : creating instance
JobURL       : https://github.com/sourcegraph/cloud/actions/runs/9251869285
JobState     : completed
Overall      : failure

@burmudar burmudar requested review from a team and filiphaftek May 27, 2024 11:05
@burmudar burmudar self-assigned this May 27, 2024
@cla-bot cla-bot Bot added the cla-signed label May 27, 2024
@burmudar burmudar force-pushed the wb/sg/update-cloud-status-format branch from cc91d38 to 41c7f99 Compare May 27, 2024 11:06
@burmudar burmudar merged commit 1cc764e into main May 27, 2024
@burmudar burmudar deleted the wb/sg/update-cloud-status-format branch May 27, 2024 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants