This repository was archived by the owner on Sep 30, 2024. It is now read-only.
privateApp to set first_source_url contact property on HubSpot#62920
Merged
Conversation
dadlerj
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on conversations with the marketing team, they would like the PrivateApp to update
first_source_urlcontact property with the cookiefirst_page_seen_urlon login/sign up flows. Sincelast_page_seen_urlis updated every time seomeone goes to a new page, thefirst_source_urlis not actually a source of truth using the backfill method they had planned to use. It becomes whatever page they were just on, not the first page they landed on.Full thread here
Test plan
simple change, test via CI