Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(release): add changelog section to pr template#62902

Merged
jhchabran merged 2 commits into
mainfrom
jh/changelog-pr-template
May 28, 2024
Merged

chore(release): add changelog section to pr template#62902
jhchabran merged 2 commits into
mainfrom
jh/changelog-pr-template

Conversation

@jhchabran

@jhchabran jhchabran commented May 24, 2024

Copy link
Copy Markdown
Contributor

See https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c?pvs=4 for the context about this edit to the default template.

This PR updates the default PR template to have a ## Changelog section to guide teammates into writing entries which are then crawled in order to automatically generate the changelog in the docs repo.

Changelog

  • Added instructions to guide teamates into writing changelog entries directly in their PR descriptions.

Test plan

No testing required, this is merely a content update of the PR template, there's nothing to break.

@cla-bot cla-bot Bot added the cla-signed label May 24, 2024
@jhchabran jhchabran requested review from a team and craigfurman and removed request for a team May 24, 2024 13:52

@craigfurman craigfurman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

My only comment: there probably should be a facility to not actually require all PRs to result in changelog entries. While every user-facing change should have a changelog, not all commits result in user-facing changes. For example, the use of feature flags to trickle code into main before actually exposing a feature to users is arguably good practice. We're actually doing this right now in the release team, merging appliance-related features into main, but since this is a brand new component, nothing is user-visible yet.

@Chickensoupwithrice

Chickensoupwithrice commented May 24, 2024

Copy link
Copy Markdown
Contributor

I think we should have a call out for intended readers of the changelog. It's not just for customers, but also TS/CSE. Keeping them in mind when writing changelogs will hopefully lead to better changelogs being written at the source of truth.

We only document the HOW here, but including a line about the WHY or WHO would be a good idea imo

@jhchabran

jhchabran commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

🚀

My only comment: there probably should be a facility to not actually require all PRs to result in changelog entries. While every user-facing change should have a changelog, not all commits result in user-facing changes. For example, the use of feature flags to trickle code into main before actually exposing a feature to users is arguably good practice. We're actually doing this right now in the release team, merging appliance-related features into main, but since this is a brand new component, nothing is user-visible yet.

@craigfurman You mentioned commit here, just in case it's not clear, this operates at the PR level, commits are ignored.

I mentioned your question in the FAQ entry already, TL;DR is I'd rather have a changelog in every PR and filter them out at the end, than making folks think whether or not they want to write a changelog entry. I believe that this way, we'll have more of those.

We only document the HOW here, but including a line about the WHY or WHO would be a good idea imo

@Chickensoupwithrice added a quick audience sentence.

@jhchabran jhchabran enabled auto-merge (squash) May 28, 2024 13:04
@jhchabran jhchabran merged commit a6769ef into main May 28, 2024
@jhchabran jhchabran deleted the jh/changelog-pr-template branch May 28, 2024 13:06
@craigfurman

Copy link
Copy Markdown
Contributor

@jhchabran ah yes, sorry, I must have missed that in the FAQ. I'll take the conversation to https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c?pvs=4#833ebe65b29241bc8c11472b8f58d908 since this already merged. I do have a follow-up comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants