This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Update blobstore package to remove unused port + ssl properties#62882
Merged
Conversation
willdollman
approved these changes
May 24, 2024
Contributor
|
I'll merge this now as there's a bit of time pressure to hit the release on monday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blobstore container exposed port with test ssl keys configured
The blobstore will have just the http port (probably 9000) and we disabled the unused port(ssl)
Blobstore container had unused port open configured with test private keys. After investigating about the unused port, we decided to remove config in the image from upstream
sourcegraph/s3proxyTest plan
Additional testing
docker exec -u 0 -it blobstore sh curl -i -X PUT http://127.0.0.1:9000/create-bucket-test-2022-01-09-attempt0