This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: remove site-admin-only data from repo popover#62834
Merged
Conversation
bf145e8 to
32dd32b
Compare
fkling
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo popover has deployed to S2, but it's not visible to anyone who is not a site admin because one of the GraphQL fields used is restricted to only site admins.
This updates the query to use a non-restricted field, and also fixes the code host capitalization while I'm at it.
Additionally, if there is an error, it now displays it in the popover so it should be easier to catch these in the future.
Test plan
Manually tested it still works when I use a user with no site admin permissions. This is a great motivator for getting solid end-to-end tests working 🙂