This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/cody: new site config for smart context#62802
Merged
Merged
Conversation
- Add `SmartContext` field to `CompletionsConfig` struct - Implement `SmartContext()` method in `codyLLMConfigurationResolver` - Set default `SmartContext` value to "enabled" if not provided - Update schema and documentation to describe `SmartContext` feature
f3b8a93 to
170845c
Compare
2 tasks
arafatkatze
approved these changes
May 21, 2024
arafatkatze
left a comment
Contributor
There was a problem hiding this comment.
Verified and tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSE https://github.com/sourcegraph/cody-issues/issues/76
See the linked issue for details.
Objectives:
SmartContextSmartContextis default to "enabled"ChatModelMaxTokensto indicate it is not respected ifSmartContextis enabled, and that instead, Cody will determine the max tokens to use based on the model nameChanges:
SmartContextfield toCompletionsConfigstructSmartContext()method incodyLLMConfigurationResolverSmartContextvalue to "enabled" if not provided, and "disabled" to disable the featureSmartContextfeaturechatModelMaxTokensregarding how it would be overrides whenSmartContextis enabledTest plan
sg startfrom this branch to start a Sourcegraph instance locallyRUNthe graphQL query below that the Cody clients would call"completions.smartContext"is not configured in your site configurations, it will be defaulted to "enabled":"completions.smartContext"to "disabled"graphQL query