This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Backport: Client Compatible Bedrock ARN handling (#62720)#62793
Merged
Conversation
* Improve Bedrock ARN handling * Fix up PR comments (cherry picked from commit 6a7666c)
| // Bedrock Model IDs can be in one of two forms: | ||
| // - A static model ID, e.g. "anthropic.claude-v2". | ||
| // - A model ID and ARN for provisioned capacity, e.g. | ||
| // "anthropic.claude-v2/arn:aws:bedrock:us-west-2:012345678901:provisioned-model/xxxxxxxx" |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: security-semgrep-rules.semgrep-rules.secret.match-aws-arn
| Model string | ||
| // If the configuration is using provisioned capacity, this will | ||
| // contain the ARN of the model to use for making API calls. | ||
| // e.g. "anthropic.claude-v2/arn:aws:bedrock:us-west-2:012345678901:provisioned-model/xxxxxxxx" |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: security-semgrep-rules.semgrep-rules.secret.match-aws-arn
|
|
||
| // Check for bedrock Provisioned Capacity ARNs which should instead be | ||
| // formatted like: | ||
| // "anthropic.claude-v2/arn:aws:bedrock:us-west-2:012345678901:provisioned-model/xxxxxxxx" |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: security-semgrep-rules.semgrep-rules.secret.match-aws-arn
craigfurman
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Bedrock ARN handling
Fix up PR comments
(cherry picked from commit 6a7666c)
This PR ensures that the Bedrock Provisioned Capacity ARN model IDs are handled correctly.
Test plan