This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix: Show full info for highlighter errors#62779
Merged
Merged
Conversation
varungandhi-src
commented
May 18, 2024
Contributor
Author
There was a problem hiding this comment.
Previously, this was:
{"error": "/scip endpoint"}
Previously, if you made a malformed request, the actual error would not be shown because the default anyhow to_string impl would only take the top-most context into account, which would be something like '/scip endpoint'.
f428671 to
7074172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if you made a malformed request, the actual error
would not be shown because the default anyhow to_string impl
would only show the top-most context attached to the error
(see: https://docs.rs/anyhow/latest/anyhow/struct.Error.html#display-representations),
which would be something like
/scip endpoint.Test plan
Added snapshot test