This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Factor out logic for modifying site config#62768
Merged
Conversation
varungandhi-src
commented
May 17, 2024
Contributor
Author
There was a problem hiding this comment.
This part is the main 'logic' change, where we're using the global client instead of the client passed in as the argument. I can make the logic more complex to accommodate the locally passed client, but strictly speaking, all these tests run serially, so I think this is OK?
Multiple integration tests have essentially the same code for modifying the site config, and then resetting it to it original state. Refactor that out into a common method.
38b124c to
1cef938
Compare
Contributor
Author
|
cc @stefanhengl @pjlast could you review/approve? |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple integration tests have essentially the same code for
modifying the site config, and then resetting it to it original
state. Refactor that out into a common method.
Test plan
Covered by existing tests