Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Fix up "Manage team" page UI#62761

Merged
vdavid merged 14 commits into
mainfrom
dv/fixup-manage-team
May 20, 2024
Merged

Fix up "Manage team" page UI#62761
vdavid merged 14 commits into
mainfrom
dv/fixup-manage-team

Conversation

@vdavid

@vdavid vdavid commented May 17, 2024

Copy link
Copy Markdown
Contributor

@rrhyne left a bunch of feedback in this figma and this Loom that I totally overlooked at first.

This PR contains all the fixes listen in the Figma and Loom (unless I mixed something).

This is a complete list:

  • Page
    • Added missing page title
    • Removed "open in new" icon from "Manage subscription" link
    • Made the "Add seats" button be of the "success" type (green) rather than "primary" (blue)
  • Invites
    • Fixed textarea label copy
    • Added a red outline to textbox if the input has an error
    • Made the error text replace the help text in case of an error
    • Left-aligned "Send" button
  • Team member list
    • Converted the list to a table-like arrangement
    • Updated "Re-send invite" button type to "secondary" (outline)
    • Center-aligned action buttons
    • Fix copy: "Resend" → "Re-send" to match the figma

Also:

  • Code cleanup: Removed an unneeded condition) – see separate commit
  • Use text-uppercase class in ADMIN and INVITED labels

Test plan

Here is a 2.5-minute Loom where I demo the changes.

@cla-bot cla-bot Bot added the cla-signed label May 17, 2024
@vdavid vdavid changed the title Dv/fixup manage team Fix up "Manage team" page UI May 17, 2024
@vdavid vdavid requested review from a team and rrhyne May 17, 2024 13:25
@vdavid vdavid marked this pull request as ready for review May 17, 2024 13:25
Comment on lines 240 to 242

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these empty divs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the grid layout needs five columns. If I don't include the empty divs, the layout gets messed up. Tried it.

Comment thread client/web/src/cody/team/TeamMemberList.tsx Outdated

@taras-yemets taras-yemets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. Left a few minor comments inline.

@vdavid vdavid force-pushed the dv/fixup-manage-team branch from 0505815 to 9aac55b Compare May 20, 2024 09:12
@vdavid vdavid enabled auto-merge (squash) May 20, 2024 10:36
@vdavid vdavid merged commit 4301253 into main May 20, 2024
@vdavid vdavid deleted the dv/fixup-manage-team branch May 20, 2024 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants