This repository was archived by the owner on Sep 30, 2024. It is now read-only.
svelte: Fix various z-index/layering issues#62726
Merged
Merged
Conversation
While looking into #62713 I stumbled upon two z-index issues. This commit removes a bunch of z-index settings to simplifying layering. - Instead of setting a z-index on the header to make the sidebar navigation work, we can "portal" the sidebar to the end of the document. - Likewise the repo search input is portalled to ensure that it renders above all other content.
fkling
commented
May 16, 2024
Comment on lines
-153
to
-156
| // Ensure that any content inside navigation portal block | ||
| // can't overlap any static content like sidebar navigation | ||
| // in the global header layout. | ||
| isolation: isolate; |
Contributor
Author
There was a problem hiding this comment.
If this is set, the search input in the header is not above the main page content.
Comment on lines
-65
to
-68
| // This seems needed to prevent the file headers (which are position: sticky) from overlaying | ||
| // the search input. Alternatively we could portal the search input with melt, but then | ||
| // it would be more difficult to position it over the repo header. | ||
| z-index: 2; |
Contributor
Author
There was a problem hiding this comment.
This isn't relevant anymore since the header is now merged into the global navbar.
vovakulikov
approved these changes
May 16, 2024
vovakulikov
left a comment
Contributor
There was a problem hiding this comment.
Cool, I had a though in my last PR about z-indexes, look much simpler and more relieble
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into #62713 I stumbled upon two z-index issues:
I'm worried that layering already gets out of hand and is difficult to understand. So this commit removes a bunch of z-index settings to simplifying this.
Most importantly:
Test plan
Opened popovers/tooltips/etc on various pages:
experimentalpopover