This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(ci): docker-images runtype#62708
Merged
Merged
Conversation
Contributor
It was building and shipping containers while skipping the tests. It was the escape hatch for emergency scenarios where you need an image right now. Did you ask on Slack somewhere about this ? |
8acb185 to
daeb2c2
Compare
jhchabran
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on this thread, the conclusion was to create a new runtype with the behavior of
main-dry-runwithpush_prod=true. I created the run type and just included it everywhere themain-dry-runtype was used.I don't understand how that accomplishes what
docker-images-candidates-notestwas doing, but c'est la vie.Test plan
Will run on buildkite.
(EDIT @jhchabran): https://buildkite.com/sourcegraph/sourcegraph/builds/275755#018fb9e2-98b1-45e7-b311-7d420c8edc8e