This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Docs: update integration test instructions#62679
Merged
Merged
Conversation
jtibshirani
commented
May 14, 2024
| ``` | ||
| Steps: | ||
| 1. Request "CI Secrets Read Access" in Entitle | ||
| 2. Run `sg bazel test //testing:backend_integration_test` |
Contributor
Author
There was a problem hiding this comment.
I'm not 100% sure this works, as I wasn't able to do this successfully (which was maybe because I'm on Mac OS??)
Member
There was a problem hiding this comment.
I think we actually want sg test bazel-backend-integration, which is the setup that actually uses the entitle permissions. Otherwise, the required env vars won't be set.
I haven't tested this in a while though, so YMMV 🙂
Contributor
Author
There was a problem hiding this comment.
Thanks for the correction!
jtibshirani
commented
May 14, 2024
| - Delete new users created during the test. | ||
| - Delete external services created during the test. | ||
| - Although, sometimes you would not want to delete an entity so you could login and inspect the failure state. | ||
| - Prefix your branch name with `backend-integration/` will run integration tests in CI on your pull request. |
Contributor
Author
There was a problem hiding this comment.
This didn't seem helpful, as we always run integration tests on pull requests 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the README for GraphQL integration tests to encourage devs to
run them in CI instead of running locally. It also update the local
instructions to use the correct target.
Test plan
Tested these instructions manually