Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

sg msp: add category flag for 'tfc sync'#62675

Merged
bobheadxi merged 2 commits into
mainfrom
sg-msp-tfc-sync-all
May 15, 2024
Merged

sg msp: add category flag for 'tfc sync'#62675
bobheadxi merged 2 commits into
mainfrom
sg-msp-tfc-sync-all

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

Enables staged rollouts of workspace updates.

Test plan

sg msp tfc sync -all -category=test

@cla-bot cla-bot Bot added the cla-signed label May 14, 2024
@bobheadxi bobheadxi requested a review from a team May 14, 2024 20:06

@jac jac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rather than saying "must be used with '-all'" it might be clearer to say "can only be used with -all" as, at least to me, the current wording could also imply that "-all" requires "-category" to be specified

@bobheadxi

Copy link
Copy Markdown
Member Author

Good call @jac , I updated it and all similar occurrences!

@bobheadxi bobheadxi merged commit 2d3b2c2 into main May 15, 2024
@bobheadxi bobheadxi deleted the sg-msp-tfc-sync-all branch May 15, 2024 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants