This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Update HubSpot contacts integration#62667
Merged
Merged
Conversation
dadlerj
reviewed
May 20, 2024
dadlerj
left a comment
Member
There was a problem hiding this comment.
Thanks! This looks great. Just a few comments and then good to go
Member
There was a problem hiding this comment.
I think you're missing last_page_seen_url
Contributor
Author
There was a problem hiding this comment.
There's no last_page_seen_url HubSpot contact property, instead we're updating the last_source_url Contact Property(as its connected to custom workflows) with the new last_page_seen_url Cookie that gets created/set on GTM.
dadlerj
approved these changes
May 23, 2024
|
(Notifying @sourcegraph/source of a change that affects gitserver) |
eseliger
reviewed
May 23, 2024
Based on new cookies added to the GTM script, we are updating our private app integration to capture these values on a signup/sigin flow.
5853548 to
a62613e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on new cookies added to the GTM script, we are updating our private app integration to capture these values on a signup/sigin flow. The Google Tag Manager script only updates properties on HubSpot when a HubSpot form is completed and not during a regular sign-in/sign-up flow.
Test plan
Test via CI and see if I can test with a local deployment