You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Transcribes from https://docs.google.com/spreadsheets/d/1Vu-Nk0dSCDJb_1cffbd29sr3NQkhJAmVAU9x_M7TnTU/edit#gid=0 into Bazel tags as part of #60455. Includes a quick script dev/check-test-ownership.sh that reports the % of tests that have an owning team assigned to them.
We exclude certain types of tests due to their irrelevance (mostly things in e.g. ./.aspect, ./docs and diff tests that just check to make sure generated files are as expected).
Once we have this data being fed into BigQuery, we can start including it in our Redash dashboards.
A follow-up PR will be required that checks in CI to make sure we don't fall below the 70% ownership threshold outlined by the OKR.
Test plan
Not changing any logic about anything, just metadata about the build
I wonder if this could be implemented using owner/codeowner files or so. That way we would get Own data in Sourcegraph on tests as well 😬
I had originally looked into that, but it operates at a different level than we'd want and there doesn't appear to be the same level of query-ability vs bazel query. Having it as part of bazel tags gives us a 1:1 relationship with the data that we consume from bazel for test timings/cache hits/etc, and an easy way to find what test targets aren't covered. We also get to avoid checking out sg/sg in https://buildkite.com/sourcegraph/devx-build-metrics for every data upload we perform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transcribes from https://docs.google.com/spreadsheets/d/1Vu-Nk0dSCDJb_1cffbd29sr3NQkhJAmVAU9x_M7TnTU/edit#gid=0 into Bazel tags as part of #60455. Includes a quick script dev/check-test-ownership.sh that reports the % of tests that have an owning team assigned to them.
We exclude certain types of tests due to their irrelevance (mostly things in e.g. ./.aspect, ./docs and diff tests that just check to make sure generated files are as expected).
Once we have this data being fed into BigQuery, we can start including it in our Redash dashboards.
A follow-up PR will be required that checks in CI to make sure we don't fall below the 70% ownership threshold outlined by the OKR.
Test plan
Not changing any logic about anything, just metadata about the build