This repository was archived by the owner on Sep 30, 2024. It is now read-only.
msp/terraform: upgrade to 1.7.5#62650
Merged
Merged
Conversation
jac
approved these changes
May 14, 2024
bobheadxi
referenced
this pull request
in sourcegraph/managed-services-platform-cdktf
May 14, 2024
See https://github.com/sourcegraph/sourcegraph/pull/62650 for context: > We need to upgrade to use `import` blocks (TF 1.5), which will make https://github.com/sourcegraph/sourcegraph/pull/62644 and CORE-23 capable of a smooth rollout (otherwise we encounter conflict with the previously hand-deployed resources). This change upgrades the version of Terraform and CDKTF to use when generating these packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://developer.hashicorp.com/terraform/language/v1.7.x/upgrade-guides this should be compatible with our current version, 1.3.10
We need to upgrade to use
importblocks (TF 1.5), which will make https://github.com/sourcegraph/sourcegraph/pull/62644 and CORE-23 capable of a smooth rollout (otherwise we encounter conflict with the previously hand-deployed resources).This also requires our CDKTF modules to be regenerated with the new Terraform version: sourcegraph/managed-services-platform-cdktf#10
Test plan
n/a - will do a staged rollout per https://www.notion.so/sourcegraph/MSP-infrastructure-upgrades-1808e7e45bd54f419dd93af542d99238?pvs=4