This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg/msp: add cloud deploy pubsub notifications#62596
Merged
Merged
Conversation
unknwon
approved these changes
May 10, 2024
unknwon
left a comment
Contributor
There was a problem hiding this comment.
Lots of minor suggestions, and the NOTIF thing 😁
bobheadxi
reviewed
May 10, 2024
bobheadxi
reviewed
May 10, 2024
bobheadxi
reviewed
May 10, 2024
Member
|
Also @jac , reminder to tag the relevant Linear issue - if it doesn't close it, you can use |
…manager.go Co-authored-by: Joe Chen <joe@sourcegraph.com>
…manager.go Co-authored-by: Joe Chen <joe@sourcegraph.com>
Co-authored-by: Joe Chen <joe@sourcegraph.com>
Co-authored-by: Joe Chen <joe@sourcegraph.com>
Co-authored-by: Joe Chen <joe@sourcegraph.com>
Co-authored-by: Joe Chen <joe@sourcegraph.com>
Co-authored-by: Joe Chen <joe@sourcegraph.com>
Co-authored-by: Robert Lin <robert@bobheadxi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds notifications for success and failure of cloud deploy rollouts by sending pubsub events to an endpoint.
Adds the
MSP Rolloutsbot to provisioned #alerts-- channels so it can send notifications.It adds it to all service channels even if they're not using rollouts which I think is fine
We get the endpoint to send notifications to from a secret in
sourcegraph-secretsCloses CORE-30
Test plan
locally tested