Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

PR feedback followup#62576

Merged
camdencheek merged 1 commit into
mainfrom
cc/amd-filter
May 9, 2024
Merged

PR feedback followup#62576
camdencheek merged 1 commit into
mainfrom
cc/amd-filter

Conversation

@camdencheek

@camdencheek camdencheek commented May 9, 2024

Copy link
Copy Markdown
Member

I accidentally pushed my PR feedback commit to a different branch before merging https://github.com/sourcegraph/sourcegraph/pull/62548 🤦 This is just followup on a couple of pieces of feedback from that PR

Test plan

N/A, no change in behavior, just style.

@cla-bot cla-bot Bot added the cla-signed label May 9, 2024
@camdencheek camdencheek changed the title Followup from https://github.com/sourcegraph/sourcegraph/pull/62548 PR feedback followup May 9, 2024
@camdencheek camdencheek requested a review from ggilmore May 9, 2024 14:56
@camdencheek camdencheek marked this pull request as ready for review May 9, 2024 14:56
@camdencheek camdencheek requested a review from keegancsmith May 9, 2024 15:38

@ggilmore ggilmore left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camdencheek camdencheek merged commit a194970 into main May 9, 2024
@camdencheek camdencheek deleted the cc/amd-filter branch May 9, 2024 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants