This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Svelte]: Hide suggestion UI after query was submitted#62574
Merged
Conversation
Contributor
Author
|
This search box interaction makes me think: Should we autofocus search input on the search result page as well as on the home page, or is this too much? cc @taiyab |
Contributor
I think so, yes. |
camdencheek
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/62572
Not the ideal solution but cheap one, I'm curious what @fkling
thinks about having this as standard behavior for suggestion logic.
Screen.Recording.2024-05-09.at.14.36.24.mov
Test plan