This repository was archived by the owner on Sep 30, 2024. It is now read-only.
rockskip: ruler function is just bits.TrailingZeros#62567
Merged
Conversation
I couldn't help but make this change after seeing the algorithm. Feel free to just close this if this makes it less clear, but this kinda feels clearer in my head but I am probably weird. Test Plan: TestRuler passes
jtibshirani
approved these changes
May 9, 2024
jtibshirani
left a comment
Contributor
There was a problem hiding this comment.
I like this, it's clear to me at least :) Could you add a short comment because it's not 100% obvious this is equivalent?
Member
Author
|
@jtibshirani updated with a comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't help but make this change after seeing the algorithm in https://github.com/sourcegraph/sourcegraph/pull/62510. Feel free to just close this if this makes it less clear, but this kinda feels clearer in my head but I am probably weird.
Test Plan: TestRuler passes