This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore/release: remove slack webhook requirement#62556
Merged
Merged
Conversation
BolajiOlajide
commented
May 8, 2024
Comment on lines
-18
to
-33
| # `write_builds` permission is all that's needed here | ||
| # You also need to ensure you add access to the Sourcegraph organization on Buildkite. | ||
|
|
||
| # announce-engineering slack webhook url: | ||
| # https://start.1password.com/open/i?a=HEDEDSLHPBFGRBTKAKJWE23XX4&v=dnrhbauihkhjs5ag6vszsme45a&i=pldpna5vivapxe4phewnqd42ji&h=team-sourcegraph.1password.com | ||
| - name: 'Slack Webhook URL' | ||
| env: SLACK_WEBHOOK_URL | ||
| only: | ||
| - promoteToPublic.finalize | ||
|
|
||
| # team-cloud-ops slack webhook url: | ||
| # https://start.1password.com/open/i?a=HEDEDSLHPBFGRBTKAKJWE23XX4&v=dnrhbauihkhjs5ag6vszsme45a&i=xwwpaakz5iajowr2fruueoevba&h=team-sourcegraph.1password.com | ||
| - name: 'Slack Webhook URL Cloud Ops' | ||
| env: SLACK_WEBHOOK_URL_CLOUD_OPS | ||
| only: | ||
| - promoteToPublic.finalize |
Contributor
Author
There was a problem hiding this comment.
promoteToPublic.finalize will be executed in the CI, so this env doesn't need to exist locally.
jdpleiness
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
Release testing