Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix/release: pass in IS_DEVELOPMENT_RELEASE flag to buildkite#62551

Merged
BolajiOlajide merged 1 commit into
5.4.0from
bo/release-promotion-fix
May 8, 2024
Merged

fix/release: pass in IS_DEVELOPMENT_RELEASE flag to buildkite#62551
BolajiOlajide merged 1 commit into
5.4.0from
bo/release-promotion-fix

Conversation

@BolajiOlajide

@BolajiOlajide BolajiOlajide commented May 8, 2024

Copy link
Copy Markdown
Contributor

Test plan

We didn't pass the IS_DEVELOPMENT env to buildkite which caused a failure when running release tests.

CleanShot 2024-05-08 at 16 28 28@2x

Changelog

  • IS_DEVELOPMENT is now correctly passed to release tooling, allowing to skip certain steps.

@BolajiOlajide BolajiOlajide self-assigned this May 8, 2024
@cla-bot cla-bot Bot added the cla-signed label May 8, 2024
@BolajiOlajide BolajiOlajide requested a review from a team May 8, 2024 15:38
@BolajiOlajide BolajiOlajide enabled auto-merge (squash) May 8, 2024 15:59
@BolajiOlajide BolajiOlajide requested a review from a team May 8, 2024 16:01
@BolajiOlajide BolajiOlajide merged commit f182cc1 into 5.4.0 May 8, 2024
@BolajiOlajide BolajiOlajide deleted the bo/release-promotion-fix branch May 8, 2024 16:01
@jhchabran jhchabran changed the title release: pass in IS_DEVELOPMENT_RELEASE flag to buildkite chore/release: pass in IS_DEVELOPMENT_RELEASE flag to buildkite May 24, 2024
@jhchabran jhchabran changed the title chore/release: pass in IS_DEVELOPMENT_RELEASE flag to buildkite fix/release: pass in IS_DEVELOPMENT_RELEASE flag to buildkite May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants