This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Rockskip: test getHops function#62549
Merged
Merged
Conversation
jtibshirani
commented
May 8, 2024
Contributor
Author
There was a problem hiding this comment.
Now it's clear the semantics are a bit weird:
- In the normal case, we always append the
NULLcommit to the end - If a commit is not present, we stop early and do not append
NULL, which can mess up downstream logic
Instead, I think we should error out if a commit isn't present. Anyways, I'm not fixing this now as I want this change to be a straight test/ refactor.
mmanela
approved these changes
May 8, 2024
ef4a0d7 to
bc03ad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another tiny warm-up for Rockskip tests. This commit adds a test for getHops
and simplifies the method.
Test plan
Added new test