This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Rockskip: simplify ruler function#62510
Merged
Merged
Conversation
mmanela
approved these changes
May 8, 2024
| if n%2 != 0 { | ||
| return 0 | ||
| } | ||
| return 1 + ruler(n/2) |
Contributor
There was a problem hiding this comment.
Out of curiosity, does go optimize away tail recursion like many functional programming languages do?
Contributor
Author
There was a problem hiding this comment.
I believe tail-call optimization is not widely implemented (https://stackoverflow.com/questions/12102675/tail-call-optimization-in-go).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test for the ruler function and simplifies the function to remove tail
recursion.
A tiny warm-up as we work on improving Rockskip test coverage.
Test plan
Added new test case.