This repository was archived by the owner on Sep 30, 2024. It is now read-only.
appliance: deploy redis services#62502
Merged
Merged
Conversation
21ed733 to
c649c35
Compare
craigfurman
commented
May 7, 2024
craigfurman
left a comment
Contributor
Author
There was a problem hiding this comment.
@jdpleiness 2 questions for you. I'm not 100% happy with the compare-helm diff yet (see above), and will take a look at that tomorrow, so no need for a full review unless you're really curious 😁
c649c35 to
2623355
Compare
added 3 commits
May 8, 2024 10:32
Helps with redis services, which have helm templates with component names including redis, redis-cache, redis-store.
2623355 to
be19114
Compare
be19114 to
055761c
Compare
craigfurman
commented
May 8, 2024
jdpleiness
approved these changes
May 8, 2024
Contributor
Author
|
Using this PR to test a new changelog generator tool feature, to exclude PRs based on a no-changelog label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appliance: delete redis-exporter config
appliance: remove unused extra env vars config fields
appliance/compare-helm: support multiple components
Helps with redis services, which have helm templates with component
names including redis, redis-cache, redis-store.
appliance: deploy redis services
Closes https://github.com/sourcegraph/sourcegraph-operator/issues/98
Test plan
Golden tests included