Viewing this in storybook fails for me with can't access property "split", filePath2 is undefined

Why did this change? Other components may be depending on being able to set --popover-border-radius

There are two values. --popover-border-radius (equal to 5px) and --border-radius (equal to 3px).

Right, why did you change the Popover component to use --border-radius?

ahhh... I see what you're saying. I'll change it.

Why did we depart from the pattern established for RepoPopover and do the data fetching in the component rather than in the +page.ts?

@camdencheek Long story short, I tried to implement it around 3 or 4 times and it was a giant pain each time, always with many bugs to work through. Why does it matter if we do it here? It seems to be better here because it's contained directly in the component that calls it. It also only mounts on hover, so we're only calling it when we need it.

In general, we want to separate data fetching from rendering because the source of the data might be different when we use the component in different places. e.g., we may want to batch these calls, or cancel a call if you hover over something different, or preload the data for some locations.

Another more concrete reason is that this is now much harder to test because, rather than just passing in the data it needs to render, you now need to mock out the API call.

Another concrete example is, if you re-hover, we now re-fetch because the component is re-created.

Okay. I see.

In that case, with the little time I have left, I think I need to cry "uncle" here and pass this along to someone else. I don't see me getting this done today. I've tried a number of times and failed to reproduce what we did with RepoPopover.