This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg: skip honey event duration if event is nil#62476
Merged
Merged
Conversation
Strum355
reviewed
May 7, 2024
Contributor
|
Not sure if we even still need any of this 🤔 we could maybe delete this as we dont check honeycomb stats for sg lint anymore |
Contributor
Author
yeah then I'll remove it |
burmudar
commented
May 7, 2024
8f74f0e to
61700dd
Compare
Strum355
reviewed
May 7, 2024
Co-authored-by: Noah S-C <noah@sourcegraph.com>
Strum355
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runScripSerializedworked fine if you ranpnpm dedupebecause it was 'instrumented' withtimeCheckbut if you didn't and executedrunScriptSerializedwithouttimeCheckthe context won't be Honeycomb enriched and thus the event will be nil and then the whole method falls apart.Previously this also just checked the locking duration of the mutex 🤔 and I assume it wanted to check the duration of the
pnpm dedupe?Either way, it now checks if the event is nil before using it.
I think this addresses #62471 and https://github.com/sourcegraph/devx-support/issues/933
Test plan
Tested locally