This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: fix badge centering#62474
Merged
Merged
Conversation
8448847 to
029f327
Compare
fkling
approved these changes
May 7, 2024
…svelte Co-authored-by: Felix Kling <felix@felix-kling.de>
9044357 to
6fbadbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes in text size made it obvious that we were not correctly centering the badge number. This fixes it by adding
display: contentsto the wrapping span that is just used for targeting an override. This way, the flexbox aligns items centered as intended.Test plan
Before:
After:
