This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add access request enabled check in backend redirect#62472
Merged
Conversation
pjlast
approved these changes
May 7, 2024
pjlast
left a comment
Contributor
There was a problem hiding this comment.
Thanks! This seems to be a better place for the check than the front-end, and handles the front-end check as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the OAuth redirect logic based on access request settings.
Currently, users without the sign-out token are redirected to OAuth login and can't make access requests.
Adjusted the OAuth middleware to prevent redirects to the sign-in page when access requests are enabled.
Test plan
Updated middleware tests to handle scenarios where access requests are either enabled or disabled.