This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat: introduce new workflow to restrict image sizes for docs#62268
Merged
Conversation
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: security-semgrep-rules.semgrep-rules.yaml.third-party-action-not-pinned-to-commit-sha
41ffd7b to
d8d000e
Compare
jhchabran
approved these changes
May 13, 2024
jhchabran
left a comment
Contributor
There was a problem hiding this comment.
I was worrying at first that removing an image that's too large in the next commit would trip the code here, but I tested it and it's all good.
LGTM
d8d000e to
a6e358e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After needing multiple attempts to get the images right in https://github.com/sourcegraph/sourcegraph/pull/62183, I'm adding this workflow to help others get automated feedback if their images are too large and should rather be in google cloud.
Test plan
Testing the workflow in this PR, see follow-up commits.
Expected failure: https://github.com/sourcegraph/sourcegraph/pull/62268/commits/22effa5aa70a13b3a7c25696086305bd3c33a69c
Expected success: https://github.com/sourcegraph/sourcegraph/pull/62268/commits/06087ea0d3953d65b7a7809497a54aa306910409