Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(rel): fix tests not waiting for push prod#62089

Merged
jhchabran merged 1 commit into
mainfrom
jh/rel/fix-release-tests
May 23, 2024
Merged

chore(rel): fix tests not waiting for push prod#62089
jhchabran merged 1 commit into
mainfrom
jh/rel/fix-release-tests

Conversation

@jhchabran

@jhchabran jhchabran commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

Problem ⬇️

image

Test plan

VERSION=v5.3.6666 BUILDKITE_COMMIT=3507614937a086847868d5e8128af7c965c50e50 RELEASE_INTERNAL=true sg ci preview -b main --format=yaml
If the current branch were to be pushed, the following pipeline would be run:
                                                                                                                                                                                                            
Parsed diff:                                                                                                                                                                                                
        changed files: [dev/ci/internal/ci/release_operations.go]                                                                                                                                                   
        diff changes: "Go"                                                                                                                                                                                          
The generated build pipeline will now follow, see you next time!                                                                                                                                            
env:                                                                                                                                                                                                        
  BUILDKITE_PULL_REQUEST: ""                                                                                                                                                                                
  BUILDKITE_PULL_REQUEST_BASE_BRANCH: ""                                                                                                                                                                    
  BUILDKITE_PULL_REQUEST_REPO: ""                                                                                                                                                                           
  CI_BUILDEVENT_DATASET: buildkite                           

# (...) 

- group: Release                                                                                                                                                                                            
  key: Release                                                                                                                                                                                              
  steps:                                                                                                                                                                                                    
  - wait                                                                                                                                                                                                    
  - agents:                                                                                                                                                                                                 
      queue: aspect-default                                                                                                                                                                                 
    command:                                                                                                                                                                                                
    - ./an "rosetta bazelrc > /tmp/aspect-generated.bazelrc; bazel --bazelrc=/tmp/aspect-generated.bazelrc                                                                                                  
      run --run_under=\"cd $$PWD &&\" //dev/sg -- release run test --branch $$BUILDKITE_BRANCH                                                                                                              
      --version $$VERSION"                                                                                                                                                                                  
    depends_on:                                                                                                                                                                                             
    - bazel-push-images   # 👈 👈 👈                                                                                                                                                                                  
    env:                                                                                                                                                                                                    
      ANNOTATE_OPTS: true -t info                                                                                                                                                                           
      DEV_REGISTRY: us.gcr.io/sourcegraph-dev                                                                                                                                                               
      PROD_REGISTRY: us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal                                                                                                                              
      TEST_REPORT_OPTS: ""                                                                                                                                                                                  
      VERSION: v5.3.6666                                                                                                                                                                                    
    key: Releasetests                                                                                                                                                                                       
    label: Release tests                                                                                                                                                                                    
    retry:                                                                                                                                                                                                  
      automatic:                                                                                                                                                                                            
      - exit_status: -1                                                                                                                                                                                     
        limit: 1                                                                                                                                                                                            
    timeout_in_minutes: "60"                                                                                                                                                                                
  - wait                                       
VERSION=v5.3.6666 BUILDKITE_COMMIT=3507614937a086847868d5e8128af7c965c50e50 RELEASE_PUBLIC=true sg ci preview -b main --format=yaml

# (...) 

- wait                                                                                                                                                                                                      
- agents:                                                                                                                                                                                                   
    queue: aspect-default                                                                                                                                                                                   
  command:                                                                                                                                                                                                  
  - ./an "rosetta bazelrc > /tmp/aspect-generated.bazelrc; bazel --bazelrc=/tmp/aspect-generated.bazelrc                                                                                                    
    run --run_under=\"cd $$PWD &&\" //dev/sg -- release run test --branch $$BUILDKITE_BRANCH                                                                                                                
    --version $$VERSION"                                                                                                                                                                                    
  env:                                                                                                                                                                                                      
    ANNOTATE_OPTS: true -t info                                                                                                                                                                             
    DEV_REGISTRY: us.gcr.io/sourcegraph-dev                                                                                                                                                                 
    PROD_REGISTRY: index.docker.io/sourcegraph                                                                                                                                                              
    TEST_REPORT_OPTS: ""                                                                                                                                                                                    
    VERSION: v5.3.6666                                                                                                                                                                                      
  key: Releasetests  # No depends_on 👈 👈 👈                                                                                                                                                                                       
  label: Release tests                                                                                                                                                                                      
  retry:                                                                                                                                                                                                    
    automatic:                                                                                                                                                                                              
    - exit_status: -1                                                                                                                                                                                       
      limit: 1                                                                                                                                                                                              
  timeout_in_minutes: "60"                                                                                                                                                                                  
- wait                 

@cla-bot cla-bot Bot added the cla-signed label Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-04-22 at 20 52 07@2x

@jhchabran jhchabran force-pushed the jh/rel/fix-release-tests branch from adcf895 to 9fb54fc Compare April 22, 2024 18:57
@jhchabran jhchabran requested review from a team and BolajiOlajide April 22, 2024 19:08
Comment thread dev/ci/internal/ci/release_operations.go Outdated
@jhchabran jhchabran force-pushed the jh/rel/fix-release-tests branch from 9fb54fc to 3507614 Compare April 22, 2024 19:16
@jhchabran jhchabran requested a review from BolajiOlajide April 22, 2024 19:17
@jhchabran jhchabran enabled auto-merge (squash) April 22, 2024 19:17
@jhchabran jhchabran disabled auto-merge April 22, 2024 19:17
@jhchabran jhchabran merged commit 7c15db3 into main May 23, 2024
@jhchabran jhchabran deleted the jh/rel/fix-release-tests branch May 23, 2024 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants