This repository was archived by the owner on Sep 30, 2024. It is now read-only.
file view: Fix code intel popovers, pinned and token navigation#61966
Merged
Conversation
Contributor
camdencheek
approved these changes
Apr 17, 2024
When upgrading and migrating rxjs methods, this way of "racing" the loading popover was incorrectly implemented. The condition needs to be reversed so that the observable completes once the non-loading tooltip was emitted.
a691917 to
95b8769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61964
When upgrading and migrating rxjs methods, this way of "racing" the loading popover was incorrectly implemented. The condition needs to be reversed so that the observable completes once the non-loading tooltip was emitted.
Test plan
Manual testing. Use token navigation to go to a token and press space. The expected popover appears.