Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.3.9104] highlight: share log attributes with trace and handle canceled#61889

Merged
keegancsmith merged 1 commit into
5.3.9104from
backport-61880-to-5.3.9104
Apr 15, 2024
Merged

[Backport 5.3.9104] highlight: share log attributes with trace and handle canceled#61889
keegancsmith merged 1 commit into
5.3.9104from
backport-61880-to-5.3.9104

Conversation

@sourcegraph-release-bot

Copy link
Copy Markdown
Collaborator

While investigating a large number of errors in highlighting I noticed the vast majority where canceled. This commit adds special handling for it and in the process does a few other things to the observability here:

  • Log duration in these errors. This is useful signal to understand if a slow request is being canceled, or we have bad debouncing in a client.
  • Re-use the tracers logger. This has many more fields and avoids duplication.
  • Downgrade cancel error to warning.
  • Include error problem in logs.
  • Factor out the snippet log field creation.

Note I didn't include snippet in the cancel log since it's unlikely to be related to the code being highlighted. Easy to add in if we find that is incorrect.

Test Plan: CI will exercise this code path. Otherwise I will follow-up on dotcom.
Backport b89b99c from #61880

While investigating a large number of errors in highlighting I noticed
the vast majority where canceled. This commit adds special handling for
it and in the process does a few other things to the observability here:

- Log duration in these errors. This is useful signal to understand if a
  slow request is being canceled, or we have bad debouncing in a client.
- Re-use the tracers logger. This has many more fields and avoids
  duplication.
- Downgrade cancel error to warning.
- Include error problem in logs.
- Factor out the snippet log field creation.

Note I didn't include snippet in the cancel log since it's unlikely to
be related to the code being highlighted. Easy to add in if we find that
is incorrect.

Test Plan: CI will exercise this code path. Otherwise I will follow-up
on dotcom.

(cherry picked from commit b89b99c)
@keegancsmith keegancsmith merged commit 1dbec80 into 5.3.9104 Apr 15, 2024
@keegancsmith keegancsmith deleted the backport-61880-to-5.3.9104 branch April 15, 2024 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants