Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.3.9104] symbols: canceling ParseRequest does not spam logs#61772

Merged
keegancsmith merged 3 commits into
5.3.9104from
backport-61719-to-5.3.9104
Apr 12, 2024
Merged

[Backport 5.3.9104] symbols: canceling ParseRequest does not spam logs#61772
keegancsmith merged 3 commits into
5.3.9104from
backport-61719-to-5.3.9104

Conversation

@sourcegraph-release-bot

Copy link
Copy Markdown
Collaborator

We are seeing lots of log spam related to cancelation of parse requests. We haven't fully tracked this down yet, but the behaviour of spamming logs in this case hides the real issue.

This adjusts the implementation in two places:

  • We introduce a parseCanceled metric so we can still track this. This is used instead of parseFailed in case of cancelation. In this case we also do not emit the "Closing failed parser" even though we are. This is due to log spam.
  • We introduce an ErrorFilter just for handleParseRequest that will elide Canceled from the logs. This is called per file. Note: we keep the error logging for canceled in the high level Parse handler which runs across all files.

Test Plan: go test. Unfortunetly that is as good as it gets for now, as I investigate the root cause further I will test this code path (and only merge once I have manually triggered and tested this code path).
Backport ae59c69 from #61719

We are seeing lots of log spam related to cancelation of parse requests.
We haven't fully tracked this down yet, but the behaviour of spamming
logs in this case hides the real issue.

This adjusts the implementation in two places:
- We introduce a parseCanceled metric so we can still track this. This
  is used instead of parseFailed in case of cancelation. In this case we
  also do not emit the "Closing failed parser" even though we are. This
  is due to log spam.
- We introduce an ErrorFilter just for handleParseRequest that will
  elide Canceled from the logs. This is called per file. Note: we keep
  the error logging for canceled in the high level Parse handler which
  runs across all files.

Test Plan: go test. Unfortunetly that is as good as it gets for now, as
I investigate the root cause further I will test this code path (and
only merge once I have manually triggered and tested this code path).

(cherry picked from commit ae59c69)
@keegancsmith keegancsmith merged commit a1cd36b into 5.3.9104 Apr 12, 2024
@keegancsmith keegancsmith deleted the backport-61719-to-5.3.9104 branch April 12, 2024 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants