Cody: add repo-level context filters support#61641
Conversation
This reverts commit 07efe05.
…cody-context-filters-to-remote-context
…cody-context-filters-to-remote-context
keegancsmith
left a comment
There was a problem hiding this comment.
I agree the dotcom cache was likely not useful. I suspect the most expensive part before was reading the ignore file from git which I imagine was a pretty minor part of the work done in a codycontext request.
| } | ||
|
|
||
| type filtersConfig struct { | ||
| cache *lru.Cache[api.RepoID, bool] |
There was a problem hiding this comment.
There is a decent chance this cache is also not that useful given you say the size of a list of repos from the client is relatively small. However, lets leave it in and consult the prometheus metrics in the future to determine if its atleast doing something. I think the main thing this protects against is an admin generating a very large config. But I'd be tempted to just not have the cache and rather monitor response times.
There was a problem hiding this comment.
Added to the tracking issue:
Closes https://github.com/sourcegraph/sourcegraph/issues/61606
Follow-up work:
Notes to reviewers:
.cody/.ignorefile remains unchanged, it was moved as-is to a separate file (dotcom.go).Test plan