Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Add OpenAI models to supported chat models for enterprise customers#61539

Merged
taras-yemets merged 3 commits into
mainfrom
ty/add-openai-models-chat-enterprise
Apr 3, 2024
Merged

Add OpenAI models to supported chat models for enterprise customers#61539
taras-yemets merged 3 commits into
mainfrom
ty/add-openai-models-chat-enterprise

Conversation

@taras-yemets

@taras-yemets taras-yemets commented Apr 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds GPT3.5, GPT4 Turbo, GPT 4 to the list of supported chat models for enterprise (thread).

Test plan

  • CI

@taras-yemets taras-yemets requested a review from eseliger April 3, 2024 08:29
@cla-bot cla-bot Bot added the cla-signed label Apr 3, 2024
@taras-yemets taras-yemets marked this pull request as ready for review April 3, 2024 08:30
@taras-yemets taras-yemets mentioned this pull request Apr 3, 2024
Merged
@taras-yemets taras-yemets requested a review from a team April 3, 2024 08:53
vdavid
vdavid approved these changes Apr 3, 2024
View reviewed changes

@vdavid vdavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

arafatkatze
arafatkatze approved these changes Apr 3, 2024
View reviewed changes

@arafatkatze arafatkatze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as per the slack thread

eseliger
eseliger approved these changes Apr 3, 2024
View reviewed changes

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick turnaround!

@taras-yemets taras-yemets merged commit 6f84066 into main Apr 3, 2024
@taras-yemets taras-yemets deleted the ty/add-openai-models-chat-enterprise branch April 3, 2024 13:06
@chwarwick

chwarwick commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Just a note I don't think this will apply to Cloud customers, when a cloud customer is created the allowed models are set to only the models that are specified for chat & autocomplete. Check the Cloud controller codebase

cc @daxmc99

@daxmc99

daxmc99 commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

Yes, by default cloud will set these models
https://sourcegraph.sourcegraph.com/github.com/sourcegraph/controller@main/-/blob/cmd/manager/api/v1/instanceinvariants_types.go?L313-324

And our automation will continually set them back unless configured in that instance's config.yaml to use a different model.

@taras-yemets

taras-yemets commented Apr 4, 2024

Copy link
Copy Markdown
Contributor Author

@daxmc99, the main goal of this PR was to make OpenAI models allowed by default. I made a similar change to the controller repo: https://github.com/sourcegraph/controller/pull/1463 (Slack thread).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@vdavid vdavid vdavid approved these changes

@arafatkatze arafatkatze arafatkatze approved these changes

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@taras-yemets @chwarwick @daxmc99 @vdavid @arafatkatze @eseliger