Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Reapply "gitserver: Introduce FS layer to encapsulate repo name conversions (#60627)" (#61487)#61523

Merged
eseliger merged 2 commits into
mainfrom
es/gitserver-fs-take-two
Apr 2, 2024
Merged

Reapply "gitserver: Introduce FS layer to encapsulate repo name conversions (#60627)" (#61487)#61523
eseliger merged 2 commits into
mainfrom
es/gitserver-fs-take-two

Conversation

@eseliger

@eseliger eseliger commented Apr 2, 2024

Copy link
Copy Markdown
Member

This reverts commit 0e8cbca.

After the initial version didn't work for case-sensitive filesystems, this is the next attempt at shipping this.

Test plan

Tests and verified that the previous issue is resolved.

@cla-bot cla-bot Bot added the cla-signed label Apr 2, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 2, 2024
@eseliger eseliger force-pushed the es/gitserver-fs-take-two branch from 7d17e64 to b6201f4 Compare April 2, 2024 14:05
pjlast
pjlast approved these changes Apr 2, 2024
View reviewed changes

@pjlast pjlast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@eseliger eseliger marked this pull request as ready for review April 2, 2024 17:10
@eseliger eseliger merged commit 17a9768 into main Apr 2, 2024
@eseliger eseliger deleted the es/gitserver-fs-take-two branch April 2, 2024 17:20
@sentry

sentry Bot commented Apr 4, 2024 •
edited
Loading

Copy link
Copy Markdown

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ *[gitserver] performing background repo update: git command [git config sourcegraph.type git] failed with status code 255 (out...: gitcli.CommandFailedError: × github.com/sourcegraph/sourcegraph/cmd/gitserve... View Issue
  • ‼️ *[gitserver] performing background repo update: context canceled: errors.errorString: × github.com/sourcegraph/sourcegraph/internal/dat... View Issue
  • ‼️ *[gitserver] performing background repo update: context canceled: errors.errorString: × github.com/sourcegraph/sourcegraph/internal/dat... View Issue
  • ‼️ *[gitserver] performing background repo update: git command [git config sourcegraph.type git] failed with status code 255 (out...: gitcli.CommandFailedError: × github.com/sourcegraph/sourcegraph/cmd/gitserve... View Issue
  • ‼️ *[gitserver] performing background repo update: git command [git config --unset-all gc.auto] failed with status code 255 (outp...: gitcli.CommandFailedError: × github.com/sourcegraph/sourcegraph/cmd/gitserve... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pjlast pjlast pjlast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eseliger @pjlast