Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Code Insights: Log code insights alerts instead of failing while gathering repo list#61431

Merged
vovakulikov merged 1 commit into
mainfrom
vk/code-insights-skip-alert-errors
Mar 28, 2024
Merged

Code Insights: Log code insights alerts instead of failing while gathering repo list#61431
vovakulikov merged 1 commit into
mainfrom
vk/code-insights-skip-alert-errors

Conversation

@vovakulikov

Copy link
Copy Markdown
Contributor

Fixes https://github.com/sourcegraph/sourcegraph/issues/61370

Simple fix to avoid failing if search API got results with alerts, log them instead and return list of repo

Test plan

  • Check that you can resolve repositories in the creation UI with query which produce search with alerts
  • To setup these alerts you can add an empty repo to you local instance

@vovakulikov vovakulikov requested a review from a team March 27, 2024 19:06
@vovakulikov vovakulikov self-assigned this Mar 27, 2024
@cla-bot cla-bot Bot added the cla-signed label Mar 27, 2024
@vovakulikov vovakulikov merged commit 748e8b2 into main Mar 28, 2024
@vovakulikov vovakulikov deleted the vk/code-insights-skip-alert-errors branch March 28, 2024 01:31
@peterguy peterguy changed the title Code Insights: Log code insights alerts instead failing while gathering repo list Code Insights: Log code insights alerts instead of failing while gathering repo list Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Insights: Ignore alerts in search API for insight repo count resolvers

2 participants