This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Commits buttons: handle selected revision and support Perforce terminology#61408
Merged
Merged
Conversation
…page. Followup to PR #60909, which added a Commits button to the folders, and included the revision in it, expoing the shortcome of the Commits button in the repo root page, which didn't include the revision.
Contributor
eseliger
approved these changes
Mar 27, 2024
And add handling for Perforce depots, so that the button shows "changelists" for Perforce instead of "commits" and it navigates to `/-/changelists` instead of to `/-/commits`.
vovakulikov
reviewed
Mar 27, 2024
And move the `as` attribute to the top to make it clear that it renders as a link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to PR #60909, which added a Commits button to the folders, and included the revision in it, exposing the shortcoming of the Commits button in the repo root page, which didn't include the revision.
Closes #60487
Test plan
When viewing a repository root page, click the Commits button and ensure that the URL includes the current revision (branch, tag or commit).