This repository was archived by the owner on Sep 30, 2024. It is now read-only.
httpcli: add prometheus metric for monitoring the rate that Sourcegraph issues requests to external services#61348
Merged
Merged
Conversation
52d9f1f to
c4d109d
Compare
eseliger
approved these changes
Mar 28, 2024
| }, | ||
| Multi: true, | ||
| }, | ||
| { |
Member
There was a problem hiding this comment.
this lives on frontend, but it's not specific to frontend, right? I.e., we show all requests from all services here?
Contributor
Author
There was a problem hiding this comment.
Correct. The frontend dashboard includes a few different metrics like this (that are not specific to any particular microservice), so I thought this new one was similar.
8a74e74 to
dc0aa2b
Compare
…ph issues requests to external services commit-id:0f3120ed
dc0aa2b to
7683b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Prometheus metric that tracks the rate that Sourcegraph issues HTTP request that target external hosts (e.g. github.com, gitlab.com, etc.)
For every HTTP request, the metric tracks the hostname, HTTP method, and response code.
I have also added a new "External HTTP Request Rate" section the frontend Grafana dasboard that plots this metric. See the example screenshot below.
Test Plan
sg start monitoring