This repository was archived by the owner on Sep 30, 2024. It is now read-only.
minor changes#61336
Merged
Merged
Conversation
Contributor
philipp-spiess
approved these changes
Mar 22, 2024
philipp-spiess
left a comment
Contributor
There was a problem hiding this comment.
I think it's a good call. In the future, if there are issues with this approach, we can implement the stopSequence on our end too. It's confusing as to why this is not possible to set anymore in the new API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are always using the message api so I think we need to always remove the whitespace only stop sequence (made a minor edit there to remove all whitespace).
Test plan