This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.3] client: Quote language name in code nav search queries#60989
Merged
Conversation
Language names can contain spaces, and because we don't have a typed API, I made the mistake of directly concatenating the language name string to lang:, which caused an incorrect search query to be sent for code nav for Protocol Buffers, resulting in 0 code nav results. (cherry picked from commit 55d005d)
varungandhi-src
approved these changes
Mar 11, 2024
Chickensoupwithrice
approved these changes
Mar 14, 2024
7bc5f1b to
94a5eb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Language names can contain spaces, and because we don't have a typed API,
I made the mistake of directly concatenating the language name string to
lang:,which caused an incorrect search query to be sent for code nav for
Protocol Buffers,resulting in 0 code nav results.
Fixes https://github.com/sourcegraph/customer/issues/2882
Test plan
Manually confirmed that quoting fixes the issue.
Backport 55d005d from #60987